Repository navigation
feat(cosim): add network step harness and worker - #4
Merged
Merged
Conversation
Collaborator
Author
|
@deluxe2 Please check if this works for you, it's basically a port of the existing instrumentation code from the CAP/CSP repo to your repo, because it talks with player internals, and that way, we can more cleanly separate the concerns. |
Move the co-simulation adapter from the VQEG CAP-CSP pilot into SFV so that the JSON lines protocol is the only interface between the two repositories. Changes to controller internals, such as the CAP report drain, no longer need coordinated pull requests in both. - src/cosim/SFVNetworkStepHarness.js runs one controller per UE on a shared clock, applies CSP snapshots on change and drains CAP reports - src/cosim/SFVExternalTransport.js maps requests and aborts to opaque submit and cancel actions - scripts/cosim-network-step-worker.mjs is the stdin/stdout process - docs/CO_SIMULATION.md describes the messages The code is unchanged apart from imports, the class name and the removed drainCapReports guard, which only made sense across repos.
slhck
force-pushed
the
feature/cosim-network-step-harness
branch
from
November 12, 2026 08:17
baca32d to
5f5ae83
Compare
Collaborator
|
Yeah, this totally works for me 👍 I like the new interface between player and the CAP/CSP code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the co-simulation adapter that the VQEG CAP–CSP pilot uses to run SFV sessions against FikoRE. The adapter lived in the pilot repository and called SFV controller internals directly. Each change to those internals, such as the CAP report drain in #3, needed matching pull requests in both repositories. With the adapter in SFV, the JSON lines protocol is the only interface between the two.
The PR adds:
src/cosim/SFVNetworkStepHarness.js, which runs one controller per UE on a shared clock, applies CSP snapshots when they change and drains CAP reportssrc/cosim/SFVExternalTransport.js, which maps requests and aborts to opaque submit and cancel actionsscripts/cosim-network-step-worker.mjs, the stdin/stdout process the pilot startsdocs/CO_SIMULATION.md, which describes the messagestest/cosim-network-step-harness.test.jsThe code is the pilot's, apart from imports and the class name. It is based on
GenericNetworkHarness.jsandSFVExternalTransport.jsfrom SFV-VQEG-CAP-CSP-Collaboration-Experiments v0.7.2.Testing
npm test: 186 passednpm run lintandnpm run format:check: cleanOnce this is merged, the pilot will pin the merge commit and delete its copy.